Interesting. This is currently happening to me: it works perfectly in development against the sandbox and when using TestFlight but consistently fails in review. I raised a TSI for it and was told the same as you, that SKProductsRequest was returning no products. A bug was raised for the App Store Server engineers to investigate, but the problem is still present a week later. Unfortunately App Review appear to be ignoring anything I put in the review notes or send to them via the submission messaging system. I'm literally at the point of abandoning the IAP and going for a paid app because there doesn't seem to be any other way out.